Issue 5487075: code review 5487075: net: MulticastInterface and MulticastLoopback.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5487075: code review 5487075: net: MulticastInterface and MulticastLoopback. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by albert.strasheim

Modified:
13 years, 11 months ago

Reviewers:
rsc, mikio, iant

CC:
golang-dev

Visibility:
Public.

Description

net: MulticastInterface and MulticastLoopback. As far as I can see, this should work on Linux and all the BSDs. openbsd and darwin need the ip_mreqn struct and corresponding setsockopt. I'd appreciate some help getting these two platforms compiling. Relevant code in the Linux kernel: http://lxr.free-electrons.com/source/net/ipv4/ip_sockglue.c#L637

Patch Set 1 #

Patch Set 2 : diff -r 91c80f889b73 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 91c80f889b73 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
	M	src/pkg/net/udpsock_plan9.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
	M	src/pkg/net/udpsock_posix.go	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

albert.strasheim

Hello mikioh.mikioh@gmail.com, rsc@golang.org, iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-12-14 09:31:54 UTC) #1

rsc

14 years ago (2011-12-15 16:12:44 UTC) #2

I'd make the new methods call unexported
functions that live in interface_*.go.
Then you can have no-ops or error stubs
for the unsupported systems.

Expand All Messages | Collapse All Messages