Issue 5484052: Make null gl a top level config in bench

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5484052: Make null gl a top level config in bench (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by bsalomon

Modified:
12 years, 11 months ago

Reviewers:
bungeman, TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -59 lines)			Patch
	M	bench/benchmain.cpp	View		11 chunks	+89 lines, -59 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

TomH

http://codereview.appspot.com/5484052/diff/1/bench/benchmain.cpp File bench/benchmain.cpp (right): http://codereview.appspot.com/5484052/diff/1/bench/benchmain.cpp#newcode267 bench/benchmain.cpp:267: { SkBitmap::kARGB_8888_Config, "NULLGPU", kGPU_Backend, &gNullGLHelper }, Is -config NULLGPU ...

12 years, 11 months ago (2011-12-14 20:50:49 UTC) #3

bsalomon

12 years, 11 months ago (2011-12-14 21:20:38 UTC) #4

http://codereview.appspot.com/5484052/diff/1/bench/benchmain.cpp
File bench/benchmain.cpp (right):

http://codereview.appspot.com/5484052/diff/1/bench/benchmain.cpp#newcode267
bench/benchmain.cpp:267: { SkBitmap::kARGB_8888_Config,  "NULLGPU", 
kGPU_Backend, &gNullGLHelper },
On 2011/12/14 20:50:49, TomH wrote:
> Is -config NULLGPU uniform across all the tools? I thought it was lower case
on
> one of the others...

The only tool that uses null gl is bench. Before this change it was a flag
(-nullgl) that replaced the normal gl backend with null gl. Now it's a config
instead.

Expand All Messages | Collapse All Messages