Issue 5483073: lilylib.py : Wrap arguments with double quotes and clarify a comment.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5483073: lilylib.py : Wrap arguments with double quotes and clarify a comment. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by Julien Rioux

Modified:
12 years, 4 months ago

Reviewers:
Graham Percival

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

lilylib.py : Wrap arguments with double quotes and clarify a comment. I misunderstood what this function does before. On Windows we can skip the escaping of \, $, ", and ` but we still need surrounding quotes.

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	python/lilylib.py	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Julien Rioux

Final patch ready to push. http://code.google.com/p/lilypond/issues/detail?id=2107

12 years, 4 months ago (2011-12-20 14:13:56 UTC) #1

Julien Rioux

Oops here's the patch. http://code.google.com/p/lilypond/issues/detail?id=2107

12 years, 4 months ago (2011-12-20 14:14:38 UTC) #2

Graham Percival

12 years, 4 months ago (2011-12-20 15:50:47 UTC) #3

Thanks, pushed.  You're responsible for closing the issue.

Cheers,
- Graham

On Tue, Dec 20, 2011 at 03:14:38PM +0100, Julien Rioux wrote:
> Oops here's the patch.
> 
> http://code.google.com/p/lilypond/issues/detail?id=2107

Expand All Messages | Collapse All Messages