Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1112)

Issue 5477088: Build fixes for translated manuals: dependencies and a typo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by Julien Rioux
Modified:
12 years, 4 months ago
Reviewers:
Graham Percival
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Build fixes for translated manuals: dependencies and a typo Adding the texinfo stepmake template means that the translation subdirectories will use the same dependency tracking tricks as the rest of the docs.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M Documentation/cs/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/de/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/es/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/fr/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/hu/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/it/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/nl/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/zh/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M make/doc-i18n-root-rules.make View 1 chunk +2 lines, -2 lines 0 comments Download
M make/doc-i18n-root-targets.make View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Graham Percival
LGTM. Could you send me the final patch so I can push to staging immediately?
12 years, 4 months ago (2011-12-14 14:54:41 UTC) #1
Julien Rioux
On Wed, Dec 14, 2011 at 3:54 PM, <graham@percival-music.ca> wrote: > LGTM. Could you send ...
12 years, 4 months ago (2011-12-14 15:04:10 UTC) #2
Graham Percival
12 years, 4 months ago (2011-12-14 15:13:31 UTC) #3
On Wed, Dec 14, 2011 at 04:04:07PM +0100, Julien Rioux wrote:
> Sure, here it is. Please test make doc before pushing.

Nah, no need.  I've pushed it to origin/staging, which undergoes a
complete build (binaries, regtests, doc) from scratch every 6
hours.  If there's no problems, it's automatically merged with
master.

I'd normally test the patch anyway, but I've got a good feeling
about it, and if anything goes wrong it's a good test of the
script and my git branching skills to fix it.  :)

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b