Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(418)

Issue 5477054: Testing for the behavior of zero length paths, with comments to (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by Stephen Chenney
Modified:
13 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Testing for the behavior of zero length paths, with comments to indicate the preferred behavior. BUG=398 TEST=Unit testing in PathTest and a new gm test named zerolengthpaths.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -0 lines) Patch
A gm/zerolengthpaths.cpp View 1 chunk +180 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tests/PathTest.cpp View 3 chunks +93 lines, -0 lines 0 comments Download

Messages

Total messages: 1
reed1
13 years, 6 months ago (2011-12-09 21:29:10 UTC) #1
nice coding structure on the gm

Perhaps we can reduce the matrix somewhat:

1. we can assert (perhaps best as a unittest) that for all combinations of M,
MC, ML, MLC, that all of these never draw filled, and (therefore) always draw
everywhere under inverse-fill. It seems the only test requiring something visual
is stroking

2. we can assert that all stroked paths (these degenerate, and others) always
draw the same regardless of even-odd or winding filltype, and the same
regardless of inverse-even-odd or inverse-winding (since the process of stroking
always generates a winding fillpath).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b