Fix and align musicxml and input language "deutsch"

Fix and align musicxml and input language "deutsch"

Has commits:

In \language "deutsch" use b only to replace hes

The quartertone names should all be derived from h instead of b since
beh was being used inconsistently.


Fix deutsch language of musicxml2py

Use b only for hes and nothing else.  Also use asas and asah instead
of ases and aseh.

[lemzwerg, 2020-02-09 22:08:11]

LGTM

https://codereview.appspot.com/547610043/diff/567190043/scm/define-note-names...
File scm/define-note-names.scm (right):

https://codereview.appspot.com/547610043/diff/567190043/scm/define-note-names...
scm/define-note-names.scm:302: (heh . ,(ly:make-pitch -1 6 SEMI-FLAT))
What about providing an alias for the old name 'beh' for backward compatibility?

[dak, 2020-02-09 22:22:01]

On 2020/02/09 22:08:11, lemzwerg wrote:
> LGTM
> 
>
https://codereview.appspot.com/547610043/diff/567190043/scm/define-note-names...
> File scm/define-note-names.scm (right):
> 
>
https://codereview.appspot.com/547610043/diff/567190043/scm/define-note-names...
> scm/define-note-names.scm:302: (heh . ,(ly:make-pitch -1 6 SEMI-FLAT))
> What about providing an alias for the old name 'beh' for backward
compatibility?

I'd rather not since it so glaringly wrong.  All other names of kind "-eh" are
_lowered_ by a quarternote, but this one is raised.  Even if you wanted to start
it off b, it would have to be called bih (assuming quarternote enharmonicity).

[lemzwerg, 2020-02-09 22:27:55]

> > What about providing an alias for the old name 'beh'
> for backward compatibility?
> 
> I'd rather not since it so glaringly wrong.  [...]

OK, but then we need either a NEWS entry or a convert-ly rule (or both) IMHO.

[dak, 2020-02-09 23:37:40]

On 2020/02/09 22:27:55, lemzwerg wrote:
> > > What about providing an alias for the old name 'beh'
> > for backward compatibility?
> > 
> > I'd rather not since it so glaringly wrong.  [...]
> 
> OK, but then we need either a NEWS entry or a convert-ly rule (or both) IMHO.

git log -S '\<beh\>' --pickaxe-regex -- Documentation

does not show any documented German usage.  Language-specific conversion rules
are pretty heavy-handed (basically, a file needs to contain \language "deutsch"
but no other \language to have them apply, and the string "beh" is also a common
element of words like "behalten" so one needs to prune carefully).  I am
comparatively leery assuming that any preexisting detected use that isn't a
false positive in the first place has worked as intended.  But on the other
hand, there was no other way to enter heh, and it's been around like this for a
long time.  I'd rather have this done proper in 2.20.

[dak, 2020-02-10 02:07:20]

Add convert-ly rule.  Ugh.

[Be-3, 2020-02-11 20:07:13]

We still have issues with English THREE-Q-* pitches (never worked, though).

Please see my comment in musicexp.py

Torsten

https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py
File python/musicexp.py (right):

https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py#ne...
python/musicexp.py:324: return str
does not work for quartertones yet: THREE-Q-FLAT will come out as -fqf, but it
should be -tqf (like "three quarter flat").

fqf, (F SEMI-FLAT), however, must remain fqf, etc.
So, a substring-recplacement of fqf will not generally work.
It's a mess...

The same holds true for -fqs (THREE-Q-SHARP).

[Be-3, 2020-02-11 20:39:14]

Proposed solution for English
(I know that this issue is about German only, but as English has been touched,
too, by removing a pointless replace statement).

https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py
File python/musicexp.py (right):

https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py#ne...
python/musicexp.py:324: return str
Proposal:
keep 1st character and replace 'fq' by 'tq' in the suffix:

  return str[:1] + str[1:].replace ('fq', 'tq')

[dak, 2020-02-11 20:50:59]

Also fix english quarternote names in musicexp.py

[dak, 2020-02-11 20:54:19]

https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py
File python/musicexp.py (right):

https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py#ne...
python/musicexp.py:324: return str
On 2020/02/11 20:39:14, Be-3 wrote:
> Proposal:
> keep 1st character and replace 'fq' by 'tq' in the suffix:
> 
>   return str[:1] + str[1:].replace ('fq', 'tq')

Your proposal does not work for sqs.  Did an independent fix, as I have not seen
your proposal in time.  Please test since this should also still make it into
2.20.

[Be-3, 2020-02-13 03:01:18]

On 2020/02/11 20:54:19, dak wrote:
> https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py
> File python/musicexp.py (right):
> 
>
https://codereview.appspot.com/547610043/diff/557380043/python/musicexp.py#ne...
> python/musicexp.py:324: return str
> On 2020/02/11 20:39:14, Be-3 wrote:
> > Proposal:
> > keep 1st character and replace 'fq' by 'tq' in the suffix:
> > 
> >   return str[:1] + str[1:].replace ('fq', 'tq')
> 
> Your proposal does not work for sqs.  Did an independent fix, as I have not
seen
> your proposal in time.  Please test since this should also still make it into
> 2.20.

Yep, I forgot about the quarter tone sharps.

I've now successfully tested your English solution with a complete set of all
notes ranging from c to b using all accidentals in quarter tone steps from
double-flat to double-sharp.

Having a quick look at the other languages, espanol import is still completely
missing out quarter tones, even if there are Spanish quarter note names. And
portugues is completely missing.


def pitch_espanol (pitch):
    str = pitch_generic (pitch, ['do', 're', 'mi', 'fa', 'sol', 'la', 'si'],
['b', 'cb', 'cs', 's'])
    return str.replace ('bc', 'tc').replace ('sc', 'tc')

and 

def pitch_portugues (pitch):
    str = pitch_generic (pitch, ['do', 're', 'mi', 'fa', 'sol', 'la', 'si'],
['b', 'bqt', 'sqt', 's'])
    return str.replace ('bbqt', 'btqt').replace ('ssqt', 'stqt')

would do the trick, tested with the complete set.

Torsten

[Be-3, 2020-02-13 03:03:13]

German and English successfully tested.

proposal for espanol (missing quarter notes) and portuques (still completely
missing) added (as it is about 2.20)

[dak, 2020-02-13 22:40:39]

Given by Torsten Hämmerle after issue 5746 completed