Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(212)

Issue 547470044: Remove dead code throughout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by hanwenn
Modified:
4 years, 2 months ago
Reviewers:
Dan Eble, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove dead code throughout

Patch Set 1 #

Total comments: 4

Patch Set 2 : description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -89 lines) Patch
M lily/dispatcher.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M lily/freetype.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M lily/grob-array.cc View 1 chunk +1 line, -4 lines 0 comments Download
M lily/include/smobs.hh View 1 3 chunks +6 lines, -7 lines 0 comments Download
M lily/smobs.cc View 1 chunk +2 lines, -35 lines 0 comments Download
M lily/stencil-integral.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M lily/ttf.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4
lemzwerg
LGTM, thanks
4 years, 2 months ago (2020-01-24 17:51:04 UTC) #1
Dan Eble
https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh File lily/include/smobs.hh (left): https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh#oldcode316 lily/include/smobs.hh:316: SCM protection_cons_; Changing the size of a structure is ...
4 years, 2 months ago (2020-01-24 18:21:41 UTC) #2
hanwenn
description
4 years, 2 months ago (2020-01-24 18:48:43 UTC) #3
hanwenn
4 years, 2 months ago (2020-01-24 18:50:23 UTC) #4
https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh
File lily/include/smobs.hh (left):

https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh...
lily/include/smobs.hh:316: SCM protection_cons_;
On 2020/01/24 18:21:40, Dan Eble wrote:
> Changing the size of a structure is not the first thing that comes to mind
when
> someone says "dead-code removal."  I'm happy to see this change, but it could
be
> summarized a little better.

Done.

https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh
File lily/include/smobs.hh (right):

https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh...
lily/include/smobs.hh:319: Smob () { };
On 2020/01/24 18:21:40, Dan Eble wrote:
> Try this:
> 
>     Smob () = default;

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b