Issue 547470043: Explain dead code for GUILE2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 547470043: Explain dead code for GUILE2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 3 months ago by hanwenn

Modified:
4 years, 2 months ago

Reviewers:
Dan Eble, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	lily/main.cc	View		1 chunk	+3 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Dan Eble

https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc File lily/main.cc (right): https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc#newcode447 lily/main.cc:447: /* this code is dead, but keeping this around ...

4 years, 3 months ago (2020-01-24 18:05:08 UTC) #2

hanwenn

4 years, 3 months ago (2020-01-24 18:38:45 UTC) #3

https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc
File lily/main.cc (right):

https://codereview.appspot.com/547470043/diff/547480043/lily/main.cc#newcode447
lily/main.cc:447: /* this code is dead, but keeping this around until we sort
the
On 2020/01/24 18:05:08, Dan Eble wrote:
> LGTM, but ...
> 
> "'Mostly dead' is 'slightly alive.'"
> 
> It sounds like you think you might need to reinstate this.  Consider keeping
the
> #if GUILE2 and wrapping the code in if (false) {...}.  That way it will have
to
> remain compilable in the meantime, so it will be closer to ready when you need
> it.
> 
> Also, the title of this review is "Explain dead code for GUILE2," but the
change
> appears to go beyond explanation into modification.

note that the #define is GUILEV2 so this was always equivalent to #if 0

Expand All Messages | Collapse All Messages