Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(167)

Issue 546560043: Clean up problems with fret-diagram-terse markups

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by Carl
Modified:
5 years, 1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Clean up problems with fret-diagram-terse markups Clarify that only one indication per string can be created with fret-diagram-terse syntax. Add warning to fret-parse-terse-definition-string when a barre is ended on a fret without being started on that fret. As this does not change the allowed syntax, I do not feel a regtest is necessary. The warning can be seen by executing the following code: \version "2.19.82" \markup { \fret-diagram-terse "x;o;o;5-1-(;5-1;7-3-);" }

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M Documentation/notation/fretted-strings.itely View 1 chunk +4 lines, -0 lines 0 comments Download
M scm/fret-diagrams.scm View 1 chunk +7 lines, -4 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b