Issue 5465043: code review 5465043: time: use Duration for AfterFunc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5465043: code review 5465043: time: use Duration for AfterFunc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by dsymonds

Modified:
12 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

time: use Duration for AfterFunc.

Patch Set 1 #

Patch Set 2 : diff -r fafcd328da73 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fafcd328da73 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d2af700ee259 https://go.googlecode.com/hg/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -23 lines)			Patch
M	src/pkg/net/http/serve_test.go	View	1 2	7 chunks	+9 lines, -9 lines	0 comments	Download
M	src/pkg/testing/testing.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/time/sleep.go	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/time/sleep_test.go	View	1	4 chunks	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 4 months ago (2011-12-08 04:24:32 UTC) #1

rsc

LGTM Doh. Feel free to use int64(d) instead of d.Nanoseconds() here. It's what the other ...

12 years, 4 months ago (2011-12-08 04:27:44 UTC) #2

dsymonds

12 years, 4 months ago (2011-12-08 04:42:51 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=35100d466721 ***

time: use Duration for AfterFunc.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5465043

Expand All Messages | Collapse All Messages