Issue 5464048: Two minor adjustments for Google Test on Android

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5464048: Two minor adjustments for Google Test on Android

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by Peter Beverloo

Modified:
9 months, 4 weeks ago

Reviewers:

CC:
googletestframework_googlegroups.com

Base URL:
http://googletest.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Two minor adjustments for Google Test on Android The __linux__ define is set for Android builds when using Chromium code[1], but the same applies when the "ANDROID" define is available. Android uses /data/local/tmp for the temporary folder (at least on rooted devices) rather than /tmp. [1] http://codesearch.google.com/#OAMlx_jo-ck/src/build/common.gypi&exact_package=chromium&q=__linux__%20file:gyp&type=cs&l=2058

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	include/gtest/internal/gtest-port.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/gtest-port.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Peter Beverloo

Hi guys, it'd be great if you could take a look at this!

12 years, 4 months ago (2011-12-08 15:38:05 UTC) #1

Peter Beverloo

12 years, 4 months ago (2011-12-16 14:39:54 UTC) #2

On 2011/12/08 15:38:05, Peter Beverloo wrote:
> Hi guys, it'd be great if you could take a look at this!

Ping.

Expand All Messages | Collapse All Messages