Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1541)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
5462046
: Add TexStorage support (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by
bsalomon
Modified:
12 years, 8 months ago
Reviewers:
TomH
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.
Patch Set 1
#
Patch Set 2 : upload from correct ree
#
Patch Set 3 : cleanup
#
Patch Set 4 : rebase
#
Created:
12 years, 8 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+190 lines, -113 lines
)
Patch
M
include/gpu/GrGLDefines.h
View
1
2
3
2 chunks
+2 lines, -0 lines
0 comments
Download
M
include/gpu/GrGLInterface.h
View
1
2
3
2 chunks
+2 lines, -0 lines
0 comments
Download
M
src/gpu/GrGLCreateNullInterface.cpp
View
1
2
3
2 chunks
+2 lines, -0 lines
0 comments
Download
M
src/gpu/GrGLInterface.cpp
View
1
2
3
1 chunk
+1 line, -0 lines
0 comments
Download
M
src/gpu/GrGLTexture.h
View
1
2
3
3 chunks
+0 lines, -4 lines
0 comments
Download
M
src/gpu/GrGLTexture.cpp
View
1
2
3
1 chunk
+0 lines, -1 line
0 comments
Download
M
src/gpu/GrGpuGL.h
View
1
2
3
4 chunks
+10 lines, -7 lines
0 comments
Download
M
src/gpu/GrGpuGL.cpp
View
1
2
3
18 chunks
+135 lines, -101 lines
0 comments
Download
M
src/gpu/android/GrGLCreateNativeInterface_android.cpp
View
1
2
3
1 chunk
+5 lines, -0 lines
0 comments
Download
M
src/gpu/ios/GrGLDefaultInterface_iOS.cpp
View
1
2
3
1 chunk
+5 lines, -0 lines
0 comments
Download
M
src/gpu/mac/GrGLCreateNativeInterface_mac.cpp
View
1
2
3
1 chunk
+12 lines, -0 lines
0 comments
Download
M
src/gpu/mesa/GrGLCreateMesaInterface.cpp
View
1
2
3
1 chunk
+4 lines, -0 lines
0 comments
Download
M
src/gpu/unix/GrGLCreateNativeInterface_unix.cpp
View
1
2
3
1 chunk
+6 lines, -0 lines
0 comments
Download
M
src/gpu/win/GrGLCreateNativeInterface_win.cpp
View
1
2
3
1 chunk
+6 lines, -0 lines
0 comments
Download
Messages
Total messages: 3
Expand All Messages
|
Collapse All Messages
bsalomon
12 years, 8 months ago (2012-01-03 18:59:15 UTC)
#1
Sign in
to reply to this message.
TomH
LGTM
12 years, 8 months ago (2012-01-03 19:07:44 UTC)
#2
LGTM
Sign in
to reply to this message.
bsalomon
Closed with r2966
12 years, 8 months ago (2012-01-05 16:17:58 UTC)
#3
Closed with r2966
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 5462046: Add TexStorage support (Closed)
Created 12 years, 9 months ago by bsalomon
Modified 12 years, 8 months ago
Reviewers: TomH
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b