Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13548)

Issue 5460047: code review 5460047: doc/go1: document rearranged package hierarchy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by r
Modified:
12 years, 4 months ago
Reviewers:
CC:
remyoudompheng, rsc, r2, golang-dev
Visibility:
Public.

Description

doc/go1: document rearranged package hierarchy Some exciting HTML and CSS here.

Patch Set 1 #

Patch Set 2 : diff -r fafcd328da73 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 3 : diff -r fafcd328da73 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 5ea674d1b2ba https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -20 lines) Patch
M doc/all.css View 1 chunk +6 lines, -0 lines 0 comments Download
M doc/go1.html View 1 2 3 6 chunks +105 lines, -10 lines 0 comments Download
M doc/go1.tmpl View 1 2 3 6 chunks +101 lines, -10 lines 0 comments Download

Messages

Total messages: 8
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 4 months ago (2011-12-08 05:16:24 UTC) #1
r
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 4 months ago (2011-12-08 05:21:33 UTC) #2
remyoudompheng
http://codereview.appspot.com/5460047/diff/2002/doc/go1.html File doc/go1.html (right): http://codereview.appspot.com/5460047/diff/2002/doc/go1.html#newcode112 doc/go1.html:112: <tr><td>exp/template/html</td> <td>html/template</td></tr> isn't it exp/html/template ? http://codereview.appspot.com/5460047/diff/2002/doc/go1.html#newcode124 doc/go1.html:124: <tr><td>rpc</td> ...
12 years, 4 months ago (2011-12-08 07:08:53 UTC) #3
remyoudompheng
http://codereview.appspot.com/5460047/diff/2002/doc/go1.tmpl File doc/go1.tmpl (right): http://codereview.appspot.com/5460047/diff/2002/doc/go1.tmpl#newcode144 doc/go1.tmpl:144: <code>exp/html/template</code> packages have changed to <code>cmplx</code> line 110 is ...
12 years, 4 months ago (2011-12-08 07:11:13 UTC) #4
r
Hello golang-dev@googlegroups.com, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 4 months ago (2011-12-08 07:26:46 UTC) #5
rsc
LGTM http://codereview.appspot.com/5460047/diff/6001/doc/go1.tmpl File doc/go1.tmpl (right): http://codereview.appspot.com/5460047/diff/6001/doc/go1.tmpl#newcode99 doc/go1.tmpl:99: <th align="left">Old path</th> You are allowed to drop ...
12 years, 4 months ago (2011-12-08 19:32:55 UTC) #6
r2
On Dec 8, 2011, at 11:32 AM, rsc@golang.org wrote: > LGTM > > > > ...
12 years, 4 months ago (2011-12-08 19:35:14 UTC) #7
r
12 years, 4 months ago (2011-12-08 19:35:31 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=5b35b66c16dd ***

doc/go1: document rearranged package hierarchy
Some exciting HTML and CSS here.

R=remyoudompheng, rsc, r
CC=golang-dev
http://codereview.appspot.com/5460047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b