Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 545870043: Execute build scripts directly from source (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by hahnjo
Modified:
4 years ago
Reviewers:
lemzwerg, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Execute build scripts directly from source The only meaningful substitutions used by scripts/build are @PERL@ and @PYTHON@. This can be moved to the invocation, getting rid of many dependencies across directories. Also contains: - Remove unused doc-i18n-root-rules lilypond-*.info and index.*.html only exist in Documentation, not for every language. - Run grand-replace in source directory While at it, fix it for Python 3 so that I'm able to test.

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix 'make dist' #

Patch Set 3 : rebase and add dependency to compile.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -235 lines) Patch
M Documentation/GNUmakefile View 7 chunks +10 lines, -29 lines 0 comments Download
M Documentation/logo/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ly-examples/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M GNUmakefile.in View 1 6 chunks +8 lines, -19 lines 0 comments Download
M aclocal.m4 View 2 chunks +3 lines, -3 lines 0 comments Download
M configure.ac View 1 chunk +2 lines, -2 lines 0 comments Download
M elisp/GNUmakefile View 1 chunk +7 lines, -18 lines 0 comments Download
M lily/GNUmakefile View 1 chunk +2 lines, -2 lines 0 comments Download
M make/doc-i18n-root-rules.make View 2 chunks +3 lines, -15 lines 0 comments Download
M make/doc-i18n-root-targets.make View 1 chunk +1 line, -1 line 0 comments Download
M make/generic-vars.make View 1 chunk +1 line, -1 line 0 comments Download
M make/lilypond-book-rules.make View 3 chunks +3 lines, -3 lines 0 comments Download
M make/lilypond-vars.make View 3 chunks +2 lines, -4 lines 0 comments Download
M make/ly-rules.make View 1 chunk +1 line, -1 line 0 comments Download
M make/midi-rules.make View 1 chunk +1 line, -1 line 0 comments Download
M mf/GNUmakefile View 1 2 3 chunks +2 lines, -6 lines 0 comments Download
M mf/invoke-mf2pt1.sh View 1 chunk +1 line, -1 line 0 comments Download
M python/GNUmakefile View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M scripts/build/GNUmakefile View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/build/bib2texi.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/compile.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/build/create-version-itexi.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/create-weblinks-itexi.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/extract_texi_filenames.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/fix-docsize.sh View 1 chunk +1 line, -1 line 0 comments Download
M scripts/build/genicon.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/grand-replace.py View 3 chunks +1 line, -5 lines 0 comments Download
M scripts/build/help2man.pl View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/build/install.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/lilypond-words.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/build/lys-to-tely.py View 1 chunk +0 lines, -3 lines 0 comments Download
M scripts/build/make-version.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/makesnippets.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/mass-link.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/mf-to-table.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/build/mf2pt1.pl View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/build/output-distance.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/pytt.py View 3 chunks +3 lines, -5 lines 0 comments Download
M scripts/build/relative.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/build/text2html.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/build/yyout2grammar.py View 1 chunk +0 lines, -2 lines 0 comments Download
M stepmake/stepmake/generic-targets.make View 2 chunks +2 lines, -5 lines 0 comments Download
M stepmake/stepmake/generic-vars.make View 1 chunk +1 line, -1 line 0 comments Download
M stepmake/stepmake/help2man-rules.make View 1 chunk +2 lines, -42 lines 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 4 chunks +14 lines, -14 lines 0 comments Download
M stepmake/stepmake/texinfo-targets.make View 1 chunk +1 line, -1 line 0 comments Download
M vim/GNUmakefile View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 5
lemzwerg
LGTM, with some nits. https://codereview.appspot.com/545870043/diff/549860043/make/doc-i18n-root-rules.make File make/doc-i18n-root-rules.make (right): https://codereview.appspot.com/545870043/diff/549860043/make/doc-i18n-root-rules.make#newcode10 make/doc-i18n-root-rules.make:10: find $(outdir)/$* -name '*.html' | ...
4 years ago (2020-04-15 20:08:08 UTC) #1
hahnjo
On 2020/04/15 20:08:08, lemzwerg wrote: > LGTM, with some nits. > > https://codereview.appspot.com/545870043/diff/549860043/make/doc-i18n-root-rules.make > File ...
4 years ago (2020-04-15 20:56:28 UTC) #2
hanwenn
LGTM the recompiles of buildscripts are such a PITA. It's fantastic that this is now ...
4 years ago (2020-04-15 22:10:53 UTC) #3
hahnjo
fix 'make dist'
4 years ago (2020-04-16 07:36:19 UTC) #4
hahnjo
4 years ago (2020-04-17 19:52:31 UTC) #5
rebase and add dependency to compile.py
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b