Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13067)

Issue 545640044: .dir-locals.el: spell out nil settings

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by dak
Modified:
4 years, 2 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

.dir-locals.el: spell out nil settings .dir-locals.el establishes our formatting conventions when writing and formatting stuff with Emacs. Since it has been written from within Emacs using M-x add-dir-local-variable RET it spelled (indent-tabs-mode . nil) as (indent-tabs-mode) which is confusing to human readers. So the file has been changed in the repo to the more explicit form. While this will not survive further applications of M-x add-dir-local-variable RET, users are then responsible for their own differences.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M .dir-locals.el View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
lemzwerg
LGTM. Please directly push.
4 years, 2 months ago (2020-02-25 11:29:35 UTC) #1
dak
On 2020/02/25 11:29:35, lemzwerg wrote: > LGTM. Please directly push. I think the reason I ...
4 years, 2 months ago (2020-02-25 12:57:38 UTC) #2
lemzwerg
4 years, 2 months ago (2020-02-25 13:20:30 UTC) #3
> It's not urgent, is it?

No, not at all.  It just appeared to be a trivial change.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b