Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3291)

Issue 545450043: ly_scm_write_string: call scm_write directly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by hanwenn
Modified:
4 years, 2 months ago
Reviewers:
dak, thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

ly_scm_write_string: call scm_write directly Previously, this tried to get at the write function by evaluating 'write, which caused a hang on Guile 2.0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M lily/lily-guile.cc View 1 chunk +1 line, -5 lines 2 comments Download

Messages

Total messages: 3
dak
LGTM https://codereview.appspot.com/545450043/diff/583370043/lily/lily-guile.cc File lily/lily-guile.cc (right): https://codereview.appspot.com/545450043/diff/583370043/lily/lily-guile.cc#newcode55 lily/lily-guile.cc:55: scm_write(s, port); Well, I was "what the Dickens?" ...
4 years, 2 months ago (2020-01-18 23:29:30 UTC) #1
thomasmorley651
Here https://lists.gnu.org/archive/html/lilypond-devel/2019-10/msg00236.html I reported some problems, likely caused by ly_scm_write_string. Once I'll be back from ...
4 years, 2 months ago (2020-01-19 07:38:53 UTC) #2
hanwenn
4 years, 2 months ago (2020-01-24 17:21:23 UTC) #3
https://codereview.appspot.com/545450043/diff/583370043/lily/lily-guile.cc
File lily/lily-guile.cc (right):

https://codereview.appspot.com/545450043/diff/583370043/lily/lily-guile.cc#ne...
lily/lily-guile.cc:55: scm_write(s, port);
On 2020/01/18 23:29:30, dak wrote:
> Well, I was "what the Dickens?" reading this.  I suppose the original purpose
of
> the code is to follow redefinitions of "write".  I cannot imagine that to be
> overly useful, though.

I think the original code may have been from a time we didn't really understand
GUILE.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b