Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(268)

Issue 5453046: Initial reduction of make doc op - Issue 2075 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by PhilEHolmes
Modified:
12 years, 4 months ago
Reviewers:
Graham Percival
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Initial reduction of make doc op - Issue 2075 This proposed patch reduces output to 113,500 lines by pushing lilypond output to logfiles. If there is an error with lilypond-book trying to compile a lilypond file, it issues a simple error message pointing at the relevant logfile and exits.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M make/lilypond-vars.make View 1 chunk +3 lines, -3 lines 0 comments Download
M make/ly-rules.make View 1 chunk +2 lines, -2 lines 0 comments Download
M make/lysdoc-targets.make View 1 chunk +1 line, -1 line 0 comments Download
M python/lilylib.py View 1 4 chunks +4 lines, -7 lines 0 comments Download
M scripts/lilypond-book.py View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 3
PhilEHolmes
Please review simple initial patch.
12 years, 4 months ago (2011-12-05 14:41:09 UTC) #1
Graham Percival
Great start! There's a problem but I think I found out why. 1) (not the ...
12 years, 4 months ago (2011-12-07 08:03:45 UTC) #2
Graham Percival
12 years, 4 months ago (2011-12-10 04:52:22 UTC) #3
LGTM, fantastic work.  This alone will save people *hours* of frustration.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b