Issue 5452058: Fix SkGLContext FBO setup for ES2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5452058: Fix SkGLContext FBO setup for ES2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by bsalomon

Modified:
12 years, 11 months ago

Reviewers:
DerekS

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 3 : whitespace #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -12 lines)			Patch
	M	src/gpu/SkGLContext.cpp	View	1 2	1 chunk	+32 lines, -12 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

DerekS

http://codereview.appspot.com/5452058/diff/1/src/gpu/SkGLContext.cpp File src/gpu/SkGLContext.cpp (right): http://codereview.appspot.com/5452058/diff/1/src/gpu/SkGLContext.cpp#newcode44 src/gpu/SkGLContext.cpp:44: GR_GL_RGBA8, don't we want RGBA8 if we support ES2 ...

12 years, 11 months ago (2011-12-06 16:03:44 UTC) #2

bsalomon

Duh and duh. New CL addresses both comments. On 2011/12/06 16:03:44, djsollen wrote: > http://codereview.appspot.com/5452058/diff/1/src/gpu/SkGLContext.cpp ...

12 years, 11 months ago (2011-12-06 19:16:38 UTC) #3

Closed with r2812.

Expand All Messages | Collapse All Messages