Issue 5452057: Adds parenthesized measure numbers at mid-bar breaks.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5452057: Adds parenthesized measure numbers at mid-bar breaks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by MikeSol

Modified:
12 years, 3 months ago

Reviewers:
Reinhold, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Adds parenthesized measure numbers at mid-bar breaks.

Patch Set 2 : Moves formatting to Scheme #

Patch Set 3 : Rebased against current master. #

Patch Set 4 : Allows parenthesized first measure. #

Patch Set 5 : Rebase against current master. #

Patch Set 6 : Makes parenthesized numbering of first bar not-default. #

Total comments: 2

Patch Set 7 : Keeps old default behavior. #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -63 lines)			Patch
M	lily/bar-number-engraver.cc	View	1 2 3	3 chunks	+31 lines, -57 lines	0 comments	Download
M	ly/engraver-init.ly	View	1 2 3 4 5 6	1 chunk	+2 lines, -1 line	0 comments	Download
M	scm/define-context-properties.scm	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	scm/translation-functions.scm	View	1 2 3 4 5 6	2 chunks	+40 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Reinhold

http://codereview.appspot.com/5452057/diff/1/lily/bar-number-engraver.cc File lily/bar-number-engraver.cc (right): http://codereview.appspot.com/5452057/diff/1/lily/bar-number-engraver.cc#newcode107 lily/bar-number-engraver.cc:107: if (mp.main_part_ != Rational (0)) So, we now always ...

12 years, 4 months ago (2011-12-06 12:04:28 UTC) #1

Neil Puttock

12 years, 4 months ago (2011-12-12 12:15:12 UTC) #2

http://codereview.appspot.com/5452057/diff/7002/scm/define-context-properties...
File scm/define-context-properties.scm (left):

http://codereview.appspot.com/5452057/diff/7002/scm/define-context-properties...
scm/define-context-properties.scm:127: (barNumberVisibility ,procedure? "A
Procedure that takes an
You've added another arg to this

http://codereview.appspot.com/5452057/diff/7002/scm/define-context-properties...
File scm/define-context-properties.scm (right):

http://codereview.appspot.com/5452057/diff/7002/scm/define-context-properties...
scm/define-context-properties.scm:127: (barNumberFormatter ,procedure? "A
procedure that takes a bar
In keeping with other formatters, should add context arg (might simplify
engraver code further if you can access context props inside formatter)

Expand All Messages | Collapse All Messages