Issue 5451110: Fixed leak of render target associated with ColorBuffer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5451110: Fixed leak of render target associated with ColorBuffer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by apatrick1

Modified:
13 years, 9 months ago

Reviewers:
dgkoch, nicolas

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixed leak of render target associated with ColorBuffer. Following r853, I am assuming that any render target returned by FrameBuffer::getRenderTarget has to be released. Updating the usage of getRenderTarget to reflect that. This is not reproducible in Chrome at the moment but it will be once I start rendering to pbuffers. I ran the WebGL conformance tests. No regressions or crashes. Committed: http://code.google.com/p/angleproject/source/detail?r=903

Patch Set 1 #

Patch Set 2 : '' #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	src/libGLESv2/Context.cpp	View	1	3 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

apatrick1

Hi Daniel, I think I found some leaks from r853. Thanks, Al

13 years, 10 months ago (2011-12-07 03:27:15 UTC) #1

nicolas

13 years, 9 months ago (2011-12-07 16:59:54 UTC) #2

Nice catch. This may actually explain a failure to reset the device that I've
observed recently...

The patch looks good to me. Tiny nitpick: there's no need to test for "if
(renderTarget)" in readPixels.

Expand All Messages | Collapse All Messages