Issue 5450102: Changes to SkCanvas required for deferred drawing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5450102: Changes to SkCanvas required for deferred drawing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by junov1

Modified:
13 years, 6 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
	M	include/core/SkCanvas.h	View		3 chunks	+7 lines, -2 lines	2 comments	Download
	M	src/core/SkCanvas.cpp	View		2 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

Some of my questions might be removed if I could see the subclass that wants ...

13 years, 6 months ago (2011-12-06 14:49:22 UTC) #2

junov1

CL that requires these changes: http://codereview.appspot.com/5430058/

13 years, 6 months ago (2011-12-06 15:08:51 UTC) #3

junov1

13 years, 6 months ago (2011-12-06 16:45:34 UTC) #4

On 2011/12/06 15:08:51, junov1 wrote:
> CL that requires these changes: 
> http://codereview.appspot.com/5430058/

Closing this review. changes will be integrated into this CL moving forward:

http://codereview.appspot.com/5430058/

Expand All Messages | Collapse All Messages