Issue 5450068: CPP: Refactoring PhoneNumberUtil so that global scoped_ptr variables are now

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5450068: CPP: Refactoring PhoneNumberUtil so that global scoped_ptr variables are now (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by philippe

Modified:
12 years, 4 months ago

Reviewers:
lararennie

CC:
Shaopeng, georgey1

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

CPP: Refactoring PhoneNumberUtil so that global scoped_ptr variables are now hidden in an internal class. Patch contributed by Lara Rennie. Committed: http://code.google.com/p/libphonenumber/source/detail?r=407

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move logger initialization to the initializer list #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+371 lines, -336 lines)			Patch
	M	cpp/src/phonenumbers/phonenumberutil.h	View		5 chunks	+8 lines, -6 lines	0 comments	Download
	M	cpp/src/phonenumbers/phonenumberutil.cc	View	1	43 chunks	+363 lines, -330 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

lararennie

http://codereview.appspot.com/5450068/diff/1/cpp/src/phonenumbers/phonenumberutil.cc File cpp/src/phonenumbers/phonenumberutil.cc (right): http://codereview.appspot.com/5450068/diff/1/cpp/src/phonenumbers/phonenumberutil.cc#newcode641 cpp/src/phonenumbers/phonenumberutil.cc:641: logger_.reset(new StdoutLogger()); Should do logger_ in the init list

12 years, 4 months ago (2011-12-02 14:12:00 UTC) #2

philippe

12 years, 4 months ago (2011-12-02 14:32:02 UTC) #3

LGTM

Expand All Messages | Collapse All Messages