Issue 5450067: code review 5450067: gc: composite literals as per Go 1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5450067: code review 5450067: gc: composite literals as per Go 1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rsc

Modified:
12 years, 4 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: composite literals as per Go 1

Patch Set 1 #

Patch Set 2 : diff -r a1fa68d06160 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f1194e89f56f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r cc2107d49e88 https://go.googlecode.com/hg/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+186 lines, -95 lines)			Patch
M	src/cmd/gc/doc.go	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/esc.c	View	1	3 chunks	+10 lines, -0 lines	0 comments	Download
M	src/cmd/gc/fmt.c	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/cmd/gc/gen.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/gc/go.y	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/cmd/gc/lex.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/sinit.c	View	1 2	3 chunks	+29 lines, -1 line	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1 2 3	12 chunks	+83 lines, -44 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1	4 chunks	+5 lines, -38 lines	0 comments	Download
M	test/complit.go	View	1 2	3 chunks	+16 lines, -0 lines	0 comments	Download
M	test/complit1.go	View	1 2	1 chunk	+21 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 4 months ago (2011-12-02 19:13:09 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=3d4f383fcfc3 *** gc: composite literals as per Go 1 R=ken2 CC=golang-dev http://codereview.appspot.com/5450067

12 years, 4 months ago (2011-12-02 19:13:14 UTC) #2

lgtm

Expand All Messages | Collapse All Messages