Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1182)

Issue 5450048: [GPU] tile when large bitmap pased drawBitmap and only a small fraction is used (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by bsalomon
Modified:
12 years, 7 months ago
Reviewers:
TomH, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add gm images #

Patch Set 3 : remove imgs #

Patch Set 4 : cleanup #

Patch Set 5 : cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -8 lines) Patch
A gm/base-linux/drawbitmaprect_4444.png View 1 Binary file 0 comments Download
A gm/base-linux/drawbitmaprect_565.png View 1 Binary file 0 comments Download
A gm/base-linux/drawbitmaprect_8888.png View 1 Binary file 0 comments Download
A gm/base-linux/drawbitmaprect_gpu.png View 1 Binary file 0 comments Download
A gm/drawbitmaprect.cpp View 1 2 3 1 chunk +155 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache.h View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 chunks +116 lines, -8 lines 2 comments Download

Messages

Total messages: 5
bsalomon
Currently we go slow when a small subrect of a large bitmap is drawn. We ...
12 years, 7 months ago (2011-11-29 21:22:00 UTC) #1
TomH
LGTM http://codereview.appspot.com/5450048/diff/7005/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): http://codereview.appspot.com/5450048/diff/7005/src/gpu/SkGpuDevice.cpp#newcode1167 src/gpu/SkGpuDevice.cpp:1167: int tilesY = (b / tileSize) - (t ...
12 years, 7 months ago (2011-11-29 21:47:22 UTC) #2
bsalomon
http://codereview.appspot.com/5450048/diff/7005/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): http://codereview.appspot.com/5450048/diff/7005/src/gpu/SkGpuDevice.cpp#newcode1167 src/gpu/SkGpuDevice.cpp:1167: int tilesY = (b / tileSize) - (t / ...
12 years, 7 months ago (2011-11-29 21:50:11 UTC) #3
reed1
lgtm
12 years, 7 months ago (2011-11-30 15:05:45 UTC) #4
bsalomon
12 years, 7 months ago (2011-12-01 15:12:08 UTC) #5
Closed with 2760
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b