Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(483)

Issue 5449094: Adding observer pattern to SkPixelRef in order to propagate notifyPixelsChanged (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by junov1
Modified:
13 years, 6 months ago
Reviewers:
reed1
CC:
bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This change is require in order to implement the code review comment posted here: http://codereview.appspot.com/5430058/ The comment in question was: "I think this change is too broad, for all raster devices to be marked volatile. We call notifyPixelsChanged() on each draw to the device, so perhaps you can use the generationID or some other signal." Using notifyPixelsChanged is actually a much more efficient approach because it allows the the flushing of deferred draw commands to be postponed until the source image data is actually about to be invalidated. A little extra plumbing is necessary to make that happen, hence this change.

Patch Set 1 #

Patch Set 2 : patch 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1 line) Patch
M include/core/SkPixelRef.h View 1 3 chunks +42 lines, -0 lines 0 comments Download
M src/core/SkPixelRef.cpp View 2 chunks +46 lines, -1 line 0 comments Download

Messages

Total messages: 3
junov1
PTAL
13 years, 6 months ago (2011-12-05 21:49:28 UTC) #1
reed1
Can the previous CL be updated to reflect the current state of the code, + ...
13 years, 6 months ago (2011-12-05 22:04:17 UTC) #2
junov1
13 years, 6 months ago (2011-12-06 16:44:49 UTC) #3
Closing this review. changes will be integrated into this CL moving forward:

http://codereview.appspot.com/5430058/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b