Brian- I haven't had a chance yet to modify skdiff to compare these against the ...
12 years, 11 months ago
(2011-12-02 21:30:49 UTC)
#1
Brian- I haven't had a chance yet to modify skdiff to compare these against the
_8888.png images as you recommended, so this isn't actually ready to review yet
(unless you want to just look at the images on their own).
I'll try to get to the skdiff comparison on Monday. Just thought I'd send these
to you now in case they might come in handy.
Brian- This CL is now ready for review. I believe all the images here are ...
12 years, 11 months ago
(2011-12-03 11:06:35 UTC)
#2
Brian- This CL is now ready for review. I believe all the images here are good
to commit; you can see the diffs for yourself at
http://www.corp.google.com/~epoger/skdiffs/gpufiles/diffs/ .
I deleted all but 14 of the images in the CL, because these 14 are the only ones
for which we have corresponding _8888 images. (In other words, there are a
significant number of test/platform combinations for which we do not have _8888
images checked in.)
For future reference, here are the steps I took to revert the _gpu image files
for which we did not have _8888 image files, and run skdiff for the ones that
were left...
# chdir into local copy of Skia repository
cd .../trunk
# svn revert any _gpu files for which we don't have matching _8888 files
GPUFILES=$(svn status | grep _gpu.png | grep ^[AM] | awk '{print $2}')
for GPUFILE in $GPUFILES; do
CPUFILE=$(echo $GPUFILE | sed 's|_gpu.png|_8888.png|') ;
ls -l $CPUFILE || svn revert $GPUFILE;
done
# copy _8888 and _gpu images into separate directories for comparison
GPUFILES=$(svn status | grep _gpu.png | grep ^[AM] | awk '{print $2}')
TMPDIR=/tmp/gpufiles
rm -rf $TMPDIR
mkdir -p $TMPDIR/8888 $TMPDIR/gpu $TMPDIR/diffs
for GPUFILE in $GPUFILES; do
CPUFILE=$(echo $GPUFILE | sed 's|_gpu.png|_8888.png|') ;
DESTFILE=$(echo $GPUFILE | sed 's|_gpu.png|.png|' | sed 's|/|__|g') ;
cp $GPUFILE $TMPDIR/gpu/$DESTFILE;
cp $CPUFILE $TMPDIR/8888/$DESTFILE;
done
# run skdiff
make tools
BINDIR=$PWD/out/Debug
pushd $TMPDIR
$BINDIR/skdiff 8888 gpu diffs
popd
# move skdiff output into web-viewable directory
WEBDIR=~/www/skdiffs
rm -rf $WEBDIR
mkdir -p $WEBDIR
mv $TMPDIR $WEBDIR
chmod a+rx `find -P $WEBDIR -type d`
chmod a+r `find -P $WEBDIR -type f`
# After all that, the diffs between 8888 (left column)
# and gpu (right column) images can be seen at
# http://www.corp.google.com/~epoger/skdiffs/gpufiles/diffs/
LGTM. Thanks! On 2011/12/03 11:06:35, epoger wrote: > Brian- This CL is now ready for ...
12 years, 11 months ago
(2011-12-05 13:54:39 UTC)
#3
LGTM. Thanks!
On 2011/12/03 11:06:35, epoger wrote:
> Brian- This CL is now ready for review. I believe all the images here are
good
> to commit; you can see the diffs for yourself at
> http://www.corp.google.com/%7Eepoger/skdiffs/gpufiles/diffs/ .
>
> I deleted all but 14 of the images in the CL, because these 14 are the only
ones
> for which we have corresponding _8888 images. (In other words, there are a
> significant number of test/platform combinations for which we do not have
_8888
> images checked in.)
>
> For future reference, here are the steps I took to revert the _gpu image files
> for which we did not have _8888 image files, and run skdiff for the ones that
> were left...
>
>
> # chdir into local copy of Skia repository
> cd .../trunk
>
> # svn revert any _gpu files for which we don't have matching _8888 files
> GPUFILES=$(svn status | grep _gpu.png | grep ^[AM] | awk '{print $2}')
> for GPUFILE in $GPUFILES; do
> CPUFILE=$(echo $GPUFILE | sed 's|_gpu.png|_8888.png|') ;
> ls -l $CPUFILE || svn revert $GPUFILE;
> done
>
> # copy _8888 and _gpu images into separate directories for comparison
> GPUFILES=$(svn status | grep _gpu.png | grep ^[AM] | awk '{print $2}')
> TMPDIR=/tmp/gpufiles
> rm -rf $TMPDIR
> mkdir -p $TMPDIR/8888 $TMPDIR/gpu $TMPDIR/diffs
> for GPUFILE in $GPUFILES; do
> CPUFILE=$(echo $GPUFILE | sed 's|_gpu.png|_8888.png|') ;
> DESTFILE=$(echo $GPUFILE | sed 's|_gpu.png|.png|' | sed 's|/|__|g') ;
> cp $GPUFILE $TMPDIR/gpu/$DESTFILE;
> cp $CPUFILE $TMPDIR/8888/$DESTFILE;
> done
>
> # run skdiff
> make tools
> BINDIR=$PWD/out/Debug
> pushd $TMPDIR
> $BINDIR/skdiff 8888 gpu diffs
> popd
>
> # move skdiff output into web-viewable directory
> WEBDIR=~/www/skdiffs
> rm -rf $WEBDIR
> mkdir -p $WEBDIR
> mv $TMPDIR $WEBDIR
> chmod a+rx `find -P $WEBDIR -type d`
> chmod a+r `find -P $WEBDIR -type f`
>
> # After all that, the diffs between 8888 (left column)
> # and gpu (right column) images can be seen at
> # http://www.corp.google.com/%7Eepoger/skdiffs/gpufiles/diffs/
Issue 5449074: Copying in all _gpu.png actual images generated by buildbots as of r2790
(Closed)
Created 12 years, 11 months ago by epoger
Modified 12 years, 11 months ago
Reviewers: bsalomon
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0