Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1232)

Issue 5448137: code review 5448137: html/template: clean up locking for ExecuteTemplate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by r
Modified:
12 years, 3 months ago
Reviewers:
CC:
MikeSamuel, rog, golang-dev
Visibility:
Public.

Description

html/template: clean up locking for ExecuteTemplate

Patch Set 1 #

Patch Set 2 : diff -r 5190380293e8 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M src/pkg/html/template/template.go View 1 chunk +15 lines, -7 lines 0 comments Download

Messages

Total messages: 4
r
Hello mikesamuel@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 3 months ago (2011-12-07 19:23:24 UTC) #1
rog
LGTM On 7 December 2011 19:23, <r@golang.org> wrote: > Reviewers: MikeSamuel, > > Message: > ...
12 years, 3 months ago (2011-12-08 11:46:29 UTC) #2
MikeSamuel
LGTM
12 years, 3 months ago (2011-12-08 13:54:04 UTC) #3
r
12 years, 3 months ago (2011-12-08 18:15:59 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=648ada5634e3 ***

html/template: clean up locking for ExecuteTemplate

R=mikesamuel, rogpeppe
CC=golang-dev
http://codereview.appspot.com/5448137
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b