Issue 5448123: Handle methods that don't specify a response schema.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5448123: Handle methods that don't specify a response schema. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by jcgregorio_google

Modified:
12 years, 9 months ago

Reviewers:
aiuto

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 2 : Now handle requests that are in JSON format. #

Total comments: 2

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -3 lines)			Patch
M	apiclient/discovery.py	View	1	3 chunks	+8 lines, -2 lines	0 comments	Download
M	apiclient/model.py	View	1	2 chunks	+21 lines, -1 line	2 comments	Download
M	tests/data/zoo.json	View		1 chunk	+27 lines, -0 lines	0 comments	Download
M	tests/test_discovery.py	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

aiuto

lgtm, modulo the question about content-type. http://codereview.appspot.com/5448123/diff/2001/apiclient/model.py File apiclient/model.py (right): http://codereview.appspot.com/5448123/diff/2001/apiclient/model.py#newcode281 apiclient/model.py:281: content_type = 'application/json' ...

12 years, 9 months ago (2011-12-07 14:22:35 UTC) #2

jcgregorio_google

http://codereview.appspot.com/5448123/diff/2001/apiclient/model.py File apiclient/model.py (right): http://codereview.appspot.com/5448123/diff/2001/apiclient/model.py#newcode281 apiclient/model.py:281: content_type = 'application/json' Content-type is the mime-type of what ...

12 years, 9 months ago (2011-12-07 14:46:04 UTC) #3

jcgregorio_google

12 years, 9 months ago (2011-12-07 14:49:38 UTC) #4

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=ef5bdce74f4...

On 2011/12/07 14:46:04, jcgregorio_google wrote:
> http://codereview.appspot.com/5448123/diff/2001/apiclient/model.py
> File apiclient/model.py (right):
> 
> http://codereview.appspot.com/5448123/diff/2001/apiclient/model.py#newcode281
> apiclient/model.py:281: content_type = 'application/json'
> Content-type is the mime-type of what is being sent, while accept is the type
of
> stuff we will get on the response. 
> 
> On 2011/12/07 14:22:35, aiuto wrote:
> > Huh?
> > I'm sure it works, but it seems funny that you say "don't return JSON" and
the
> > type is application/json.

Expand All Messages | Collapse All Messages