Issue 5447059: Add SkWGLExtensionInterface for dealing with WGL extensions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5447059: Add SkWGLExtensionInterface for dealing with WGL extensions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bsalomon

Modified:
13 years ago

Reviewers:
reed1, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add SkWGLExtensionInterface for dealing with WGL extensions Committed: http://code.google.com/p/skia/source/detail?r=2777

Patch Set 4 : '' #

Total comments: 1

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+352 lines, -325 lines)			Patch
M	gyp/utils.gyp	View	1 2 3	3 chunks	+4 lines, -3 lines	0 comments	Download
A	include/utils/SkWGL.h	View	1 2 3	1 chunk	+90 lines, -0 lines	1 comment	Download
A +	src/utils/win/SkOSWindow_win.cpp	View	1 2 3	2 chunks	+37 lines, -161 lines	0 comments	Download
	src/utils/win/SkOSWindow_win.cpp	View	1 2 3	2 chunks	+37 lines, -161 lines	0 comments	Download
A	src/utils/win/SkWGL_win.cpp	View	1 2 3	1 chunk	+184 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

I want to add support for GLES2 contexts on desktop systems for testing purposes. Creating ...

13 years ago (2011-12-01 15:06:36 UTC) #1

TomH

LGTM http://codereview.appspot.com/5447059/diff/3001/src/utils/win/SkOSWindow_win.cpp File src/utils/win/SkOSWindow_win.cpp (right): http://codereview.appspot.com/5447059/diff/3001/src/utils/win/SkOSWindow_win.cpp#newcode285 src/utils/win/SkOSWindow_win.cpp:285: #include "SkWGL.h" Should this go at the top ...

13 years ago (2011-12-01 15:47:33 UTC) #2

reed1

http://codereview.appspot.com/5447059/diff/5003/include/utils/SkWGL.h File include/utils/SkWGL.h (right): http://codereview.appspot.com/5447059/diff/5003/include/utils/SkWGL.h#newcode76 include/utils/SkWGL.h:76: private: Now that these are private, you have the ...

13 years ago (2011-12-01 16:05:32 UTC) #3

lgtm

Expand All Messages | Collapse All Messages