Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3511)

Issue 5447059: Add SkWGLExtensionInterface for dealing with WGL extensions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by bsalomon
Modified:
12 years, 7 months ago
Reviewers:
reed1, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add SkWGLExtensionInterface for dealing with WGL extensions Committed: http://code.google.com/p/skia/source/detail?r=2777

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : '' #

Total comments: 3

Patch Set 4 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -325 lines) Patch
M gyp/utils.gyp View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
A include/utils/SkWGL.h View 1 2 3 1 chunk +90 lines, -0 lines 1 comment Download
A + src/utils/win/SkOSWindow_win.cpp View 1 2 3 2 chunks +37 lines, -161 lines 0 comments Download
src/utils/win/SkOSWindow_win.cpp View 1 2 3 2 chunks +37 lines, -161 lines 0 comments Download
A src/utils/win/SkWGL_win.cpp View 1 2 3 1 chunk +184 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bsalomon
I want to add support for GLES2 contexts on desktop systems for testing purposes. Creating ...
12 years, 7 months ago (2011-12-01 15:06:36 UTC) #1
TomH
LGTM http://codereview.appspot.com/5447059/diff/3001/src/utils/win/SkOSWindow_win.cpp File src/utils/win/SkOSWindow_win.cpp (right): http://codereview.appspot.com/5447059/diff/3001/src/utils/win/SkOSWindow_win.cpp#newcode285 src/utils/win/SkOSWindow_win.cpp:285: #include "SkWGL.h" Should this go at the top ...
12 years, 7 months ago (2011-12-01 15:47:33 UTC) #2
reed1
http://codereview.appspot.com/5447059/diff/5003/include/utils/SkWGL.h File include/utils/SkWGL.h (right): http://codereview.appspot.com/5447059/diff/5003/include/utils/SkWGL.h#newcode76 include/utils/SkWGL.h:76: private: Now that these are private, you have the ...
12 years, 7 months ago (2011-12-01 16:05:32 UTC) #3
reed1
12 years, 7 months ago (2011-12-01 16:05:50 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b