Detect teximage2d failure

[TomH, 2011-11-28 18:27:48]

Modulo 1 change LGTM.

http://codereview.appspot.com/5445045/diff/1003/src/gpu/GrGpuGL.cpp
File src/gpu/GrGpuGL.cpp (right):

http://codereview.appspot.com/5445045/diff/1003/src/gpu/GrGpuGL.cpp#newcode748
src/gpu/GrGpuGL.cpp:748: bool newTexture,
Can we have a more informative name - isNewTexture, createNewTexture, ...?

http://codereview.appspot.com/5445045/diff/1003/src/gpu/GrGpuGL.cpp#newcode833
src/gpu/GrGpuGL.cpp:833: }
I don't think it needs a comment, but I'd like to understand the pattern of
making a CALL_NOERRCHECK followed by a GET_ERROR call?

http://codereview.appspot.com/5445045/diff/1003/src/gpu/GrGpuGL.cpp#newcode1040
src/gpu/GrGpuGL.cpp:1040: GL_CALL(DeleteTextures(1, &glTexDesc.fTextureID));
Yay.

[bsalomon, 2011-11-28 18:34:22]

http://codereview.appspot.com/5445045/diff/1003/src/gpu/GrGpuGL.cpp
File src/gpu/GrGpuGL.cpp (right):

http://codereview.appspot.com/5445045/diff/1003/src/gpu/GrGpuGL.cpp#newcode748
src/gpu/GrGpuGL.cpp:748: bool newTexture,
On 2011/11/28 18:27:48, TomH wrote:
> Can we have a more informative name - isNewTexture, createNewTexture, ...?

I like isNewTexture, will change for checkin.

http://codereview.appspot.com/5445045/diff/1003/src/gpu/GrGpuGL.cpp#newcode833
src/gpu/GrGpuGL.cpp:833: }
On 2011/11/28 18:27:48, TomH wrote:
> I don't think it needs a comment, but I'd like to understand the pattern of
> making a CALL_NOERRCHECK followed by a GET_ERROR call?

The normal macro we use for GL calls may itself do a glGetErorr (for debugging
reasons, not in a normal release build). If it captures the error than to
subsequent GR_GL_GET_ERROR will not. The NO_ERRCHECK version never calls
glGetError.

[bsalomon, 2011-11-28 21:14:20]

Closed with r2756&7.