Issue 5440052: CPP: Fix logger and asyoutypeformatter unit test to let the latest release build in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5440052: CPP: Fix logger and asyoutypeformatter unit test to let the latest release build in Chromium. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by philippe

Modified:
12 years, 4 months ago

Reviewers:
Shaopeng

CC:
lararennie

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

CPP: Fix logger and asyoutypeformatter unit test to let the latest release build in Chromium. Patch contributed by georgey@chromium.org. Committed: http://code.google.com/p/libphonenumber/source/detail?r=402

Patch Set 1 #

Total comments: 1

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	cpp/src/phonenumbers/default_logger.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	cpp/test/phonenumbers/asyoutypeformatter_test.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Shaopeng

12 years, 4 months ago (2011-11-29 09:08:36 UTC) #2

LGTM

http://codereview.appspot.com/5440052/diff/1/cpp/test/phonenumbers/asyoutypef...
File cpp/test/phonenumbers/asyoutypeformatter_test.cc (right):

http://codereview.appspot.com/5440052/diff/1/cpp/test/phonenumbers/asyoutypef...
cpp/test/phonenumbers/asyoutypeformatter_test.cc:37: return
formatter_.get()->current_metadata_;
seems this change also need to happen internally.

Expand All Messages | Collapse All Messages