Cleanup in ASan interceptors

[kcc, 2011-12-04 01:20:31]

[off-topic: is llvm-commits interested in asan-rt-specific code reviews?]

http://codereview.appspot.com/5437128/diff/1/Makefile.old
File Makefile.old (right):

http://codereview.appspot.com/5437128/diff/1/Makefile.old#newcode162
Makefile.old:162: ASAN_LD_TAIL=$(LIBASAN_A)
We should not need it. 
If we still need it (what's the case?), the fix should go to clang driver. (This
might work as a temporary fix though since the makefile should die anyway)

http://codereview.appspot.com/5437128/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5437128/diff/1/asan_interceptors.cc#newcode96
asan_interceptors.cc:96: #define ENSURE_ASAN_INITED do { \
make it ENSURE_ASAN_INITED() (here and below)

http://codereview.appspot.com/5437128/diff/1/asan_interceptors.cc#newcode101
asan_interceptors.cc:101: } while (0);
remove ';'

[samsonov, 2011-12-05 11:11:44]

http://codereview.appspot.com/5437128/diff/1/Makefile.old
File Makefile.old (right):

http://codereview.appspot.com/5437128/diff/1/Makefile.old#newcode162
Makefile.old:162: ASAN_LD_TAIL=$(LIBASAN_A)
On 2011/12/04 01:20:31, kcc wrote:
> We should not need it. 
> If we still need it (what's the case?), the fix should go to clang driver.
(This
> might work as a temporary fix though since the makefile should die anyway)

Hm-m, let it be a temporary fix then. Without this change, changes in asan rtl
are not reflected when we rebuild the tests (or I'm doing smth completely
wrong).

http://codereview.appspot.com/5437128/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):

http://codereview.appspot.com/5437128/diff/1/asan_interceptors.cc#newcode96
asan_interceptors.cc:96: #define ENSURE_ASAN_INITED do { \
On 2011/12/04 01:20:31, kcc wrote:
> make it ENSURE_ASAN_INITED() (here and below)

Done.

http://codereview.appspot.com/5437128/diff/1/asan_interceptors.cc#newcode101
asan_interceptors.cc:101: } while (0);
On 2011/12/04 01:20:31, kcc wrote:
> remove ';'

Done (for all macro in this file).

[kcc, 2011-12-05 19:00:55]

> Hm-m, let it be a temporary fix then. Without this change, changes in asan rtl
> are not reflected when we rebuild the tests (or I'm doing smth completely
> wrong).
I am not sure this is a good goal, but I am sure this is a wrong solution.

[ramosian.glider, 2011-12-06 08:43:58]

Just do `make clean; make tests`
There are many implicit deps for the tests, including a dependency on Clang
itself. It's not a good idea to hard-code them all.

[samsonov, 2011-12-06 09:01:09]

On 2011/12/06 08:43:58, ramosian.glider wrote:
> Just do `make clean; make tests`
Sure I did, this doesn't work.

> There are many implicit deps for the tests, including a dependency on Clang
> itself. It's not a good idea to hard-code them all.

OK, disregard the change to Makefile then.