Issue 5437062: Add the engine preference button on ibus-setup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5437062: Add the engine preference button on ibus-setup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by fujiwara

Modified:
12 years, 5 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Add the engine preference button on ibus-setup The new preference button launches $libexecdir/ibus-setup- + engine.name by default. The engine is IBusEngineDesc. If engine.setup has a value, the button launches it instead. BUG=RH#618229 TEST=Linux desktop

Patch Set 1 #

Patch Set 2 : Synced with master #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -4 lines)			Patch
M	ibus/enginedesc.py	View	6 chunks	+9 lines, -2 lines	0 comments	Download
M	setup/ibus-setup.in	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	setup/main.py	View	4 chunks	+46 lines, -0 lines	0 comments	Download
M	setup/setup.ui	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/ibusenginedesc.h	View	1 chunk	+10 lines, -2 lines	0 comments	Download
M	src/ibusenginedesc.c	View	14 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2011/11/25 09:32:49, fujiwara wrote:

lgtm

Expand All Messages | Collapse All Messages