Issue 5437059: Don't let dots go negative in scaleDurations -- Fix Issue 2048

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5437059: Don't let dots go negative in scaleDurations -- Fix Issue 2048 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Carl

Modified:
13 years, 4 months ago

Reviewers:
Keith, pkx166h

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Don't let dots go negative in scaleDurations -- Fix Issue 2048

Patch Set 2 : Fix regtest and respond to Keith's comments #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
A	input/regression/shift-durations-negative-dots.ly	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	ly/music-functions-init.ly	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	scm/music-functions.scm	View	1	2 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Keith

Looks and works good for me. A nice thing about scheme patches is we can ...

13 years, 4 months ago (2011-11-24 18:51:21 UTC) #1

pkx166h

passes make but fails make check see http://code.google.com/p/lilypond/issues/detail?id=2048#c3 James

13 years, 4 months ago (2011-11-24 21:04:47 UTC) #2

Keith

http://codereview.appspot.com/5437059/diff/1/input/regression/shift-durations-negative-dots.ly File input/regression/shift-durations-negative-dots.ly (right): http://codereview.appspot.com/5437059/diff/1/input/regression/shift-durations-negative-dots.ly#newcode8 input/regression/shift-durations-negative-dots.ly:8: " '}' Or, we might do without a regression ...

13 years, 4 months ago (2011-11-24 23:30:36 UTC) #3

pkx166h

13 years, 4 months ago (2011-11-25 08:36:48 UTC) #4

passes make one reg test shows up

http://code.google.com/p/lilypond/issues/detail?id=2048#c5

James

Expand All Messages | Collapse All Messages