Issue 5435067: Refactoring PhoneNumberOfflineGeocoder and updating tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5435067: Refactoring PhoneNumberOfflineGeocoder and updating tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Shaopeng

Modified:
14 years ago

Reviewers:
lararennie

Base URL:
http://libphonenumber.googlecode.com/svn/trunk/

Visibility:
Public.

Refactoring PhoneNumberOfflineGeocoder and updating tests and PhoneNumberUtil. Committed: http://code.google.com/p/libphonenumber/source/detail?r=396

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
M	java/geocoder/src/com/google/i18n/phonenumbers/geocoding/PhoneNumberOfflineGeocoder.java	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	java/geocoder/test/com/google/i18n/phonenumbers/geocoding/PhoneNumberOfflineGeocoderTest.java	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	java/libphonenumber/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

LGTM