Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 5434080: Adds make-connected-path-stencil-with-initial-offset (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by MikeSol
Modified:
12 years, 4 months ago
Reviewers:
mike, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds make-connected-path-stencil-with-initial-offset

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M scm/stencil.scm View 1 chunk +23 lines, -6 lines 0 comments Download

Messages

Total messages: 2
dak
I have my problems imagining why you don't just use ly:stencil-translate on the result. If ...
12 years, 4 months ago (2011-11-29 17:33:40 UTC) #1
mike_apollinemike.com
12 years, 4 months ago (2011-11-29 18:15:19 UTC) #2
On Nov 29, 2011, at 6:33 PM, dak@gnu.org wrote:

> I have my problems imagining why you don't just use ly:stencil-translate
> on the result.
> 
> If you really want to have a separately specifiable origin, I would not
> make a separate function but rather add it as an optional argument at
> the end of the argument list.
> 

Yeah, you're right...I had just dug myself deep in a coding hole w/ a piece and
was looking for an easy way out.
I did some experimenting and it looks like your solution gives an equivalent
visual result to the patch, so I'll mark as invalid.

Cheers,
MS

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b