Issue 5433065: Asserts that footnotes are being numbered correctly.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5433065: Asserts that footnotes are being numbered correctly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by MikeSol

Modified:
13 years, 4 months ago

Reviewers:
pkx166h, carl.d.sorensen

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Asserts that footnotes are being numbered correctly.

Patch Set 2 : Incorporates Carl's suggestions. #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -11 lines)			Patch
M	input/regression/footnote-auto-numbering.ly	View		4 chunks	+25 lines, -3 lines	0 comments	Download
A	input/regression/footnote-auto-numbering-vertical-order.ly	View		1 chunk	+97 lines, -0 lines	0 comments	Download
M	lily/include/page-layout-problem.hh	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lily/page-layout-problem.cc	View		5 chunks	+22 lines, -7 lines	0 comments	Download
M	scm/define-grob-interfaces.scm	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	scm/define-grob-properties.scm	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

MikeSol

Hey all, This patch helps make sure that the footnote auto-number regtests actually test what ...

13 years, 4 months ago (2011-11-25 04:42:43 UTC) #1

Carl

LGTM, but a couple of minor comments. http://codereview.appspot.com/5433065/diff/1/scm/define-grob-interfaces.scm File scm/define-grob-interfaces.scm (right): http://codereview.appspot.com/5433065/diff/1/scm/define-grob-interfaces.scm#newcode88 scm/define-grob-interfaces.scm:88: numbering-assertion-function)) spacing. ...

13 years, 4 months ago (2011-11-28 01:38:02 UTC) #3

Passes make and make check

James

Expand All Messages | Collapse All Messages