Issue 5433055: Fix clang static analyzer errors in Gr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5433055: Fix clang static analyzer errors in Gr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bsalomon

Modified:
13 years ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : comments #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	src/gpu/GrGpuGL.cpp	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
	M	src/gpu/GrGpuGLShaders.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

TomH

http://codereview.appspot.com/5433055/diff/1/src/gpu/GrGpuGL.cpp File src/gpu/GrGpuGL.cpp (right): http://codereview.appspot.com/5433055/diff/1/src/gpu/GrGpuGL.cpp#newcode1769 src/gpu/GrGpuGL.cpp:1769: if (stencilBits) { Clearer with (stencilBits > 0) ?

13 years ago (2011-11-23 16:03:11 UTC) #2

bsalomon

13 years ago (2011-11-23 16:09:41 UTC) #3

Closed with r2743

Expand All Messages | Collapse All Messages