Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2930)

Issue 5432044: Added support for GL_ARB_texture_rectangle to shader validator. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by kbr1
Modified:
12 years, 5 months ago
Reviewers:
nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added support for GL_ARB_texture_rectangle to shader validator. Parser was regenerated with the flex/bison shipped with Ubuntu 10.04. BUG=251 http://code.google.com/p/angleproject/issues/detail?id=251 TEST=tested with new Core Animation plugin rendering path on Mac OS X Committed: http://code.google.com/p/angleproject/source/detail?r=888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1387 lines, -1512 lines) Patch
M include/GLSLANG/ShaderLang.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/common/version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/BaseTypes.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/Initialize.cpp View 6 chunks +25 lines, -25 lines 0 comments Download
M src/compiler/ShaderLang.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/VariableInfo.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/glslang.l View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/glslang.y View 2 chunks +10 lines, -1 line 0 comments Download
M src/compiler/glslang_lex.cpp View 20 chunks +359 lines, -337 lines 0 comments Download
M src/compiler/glslang_tab.h View 4 chunks +72 lines, -163 lines 0 comments Download
M src/compiler/glslang_tab.cpp View 148 chunks +912 lines, -984 lines 0 comments Download

Messages

Total messages: 2
kbr1
Hi Nicolas, Please review this small change to the shader validator. Thanks.
12 years, 5 months ago (2011-11-21 23:27:45 UTC) #1
nicolas
12 years, 5 months ago (2011-11-22 18:23:08 UTC) #2
Looks great!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b