Issue 5432044: Added support for GL_ARB_texture_rectangle to shader validator.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5432044: Added support for GL_ARB_texture_rectangle to shader validator. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by kbr1

Modified:
13 years ago

Reviewers:
nicolas

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Added support for GL_ARB_texture_rectangle to shader validator. Parser was regenerated with the flex/bison shipped with Ubuntu 10.04. BUG=251 http://code.google.com/p/angleproject/issues/detail?id=251 TEST=tested with new Core Animation plugin rendering path on Mac OS X Committed: http://code.google.com/p/angleproject/source/detail?r=888

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1387 lines, -1512 lines)			Patch
M	include/GLSLANG/ShaderLang.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/common/version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/BaseTypes.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/compiler/Initialize.cpp	View	6 chunks	+25 lines, -25 lines	0 comments	Download
M	src/compiler/ShaderLang.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/VariableInfo.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/glslang.l	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/glslang.y	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	src/compiler/glslang_lex.cpp	View	20 chunks	+359 lines, -337 lines	0 comments	Download
M	src/compiler/glslang_tab.h	View	4 chunks	+72 lines, -163 lines	0 comments	Download
M	src/compiler/glslang_tab.cpp	View	148 chunks	+912 lines, -984 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

kbr1

Hi Nicolas, Please review this small change to the shader validator. Thanks.

13 years ago (2011-11-21 23:27:45 UTC) #1

Looks great!

Expand All Messages | Collapse All Messages