Issue 5431053: fix compile-time warnings on Mac

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5431053: fix compile-time warnings on Mac

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by caryclark1

Modified:
12 years, 7 months ago

Reviewers:
bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

XCode complains that several of these files are missing linefeeds at the end of the file. Also, attachGL() failed to return a function result, so clean that up as well.

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -8 lines)			Patch
M	include/views/SkOSWindow_Mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/mac/SkNSView.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/utils/mac/SkNSView.mm	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/utils/mac/SkOSWindow_Mac.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/utils/mac/SkSampleNSView.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2011/11/23 14:29:38, caryclark1 wrote:

LGTM

Expand All Messages | Collapse All Messages