Issue 5430043: implement __has_feature(address_sanitizer)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5430043: implement __has_feature(address_sanitizer)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by kcc

Modified:
12 years, 5 months ago

Reviewers:
chandlerc

Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : use lang options only #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -6 lines)			Patch
M	include/clang/Basic/LangOptions.def	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	include/clang/Frontend/CodeGenOptions.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	lib/CodeGen/BackendUtil.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/Frontend/CompilerInvocation.cpp	View	1	4 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/Lex/PPMacroExpansion.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	test/Lexer/has_feature_address_sanitizer.cpp	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

chandlerc

12 years, 5 months ago (2011-11-22 00:42:48 UTC) #1

http://codereview.appspot.com/5430043/diff/1/lib/Frontend/CompilerInvocation.cpp
File lib/Frontend/CompilerInvocation.cpp (right):

http://codereview.appspot.com/5430043/diff/1/lib/Frontend/CompilerInvocation....
lib/Frontend/CompilerInvocation.cpp:1809: Opts.AddressSanitizer =
Args.hasArg(OPT_faddress_sanitizer);
I think you'll need to do more here.

We're now parsing the same argument in two places, which doesn't work cleanly
because we need to serialize in each place, and then we'll end up with two
serialized options.

I think we need to setup the CodeGenOpts from the language options, or use the
language options directly in the CodeGen layer. Essentially there should be one
parsing of this argument and one serialization of it

Expand All Messages | Collapse All Messages