Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4537)

Issue 5429045: Put field length constants at the top of views.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by M-A
Modified:
12 years, 5 months ago
Reviewers:
Andi Albrecht
CC:
codereview-discuss_googlegroups.com
Visibility:
Public.

Description

Put field length constants at the top of views.py Fix several inconsistencies in the field lengths depending on the form used.

Patch Set 1 #

Patch Set 2 : add MAX_FILENAME #

Patch Set 3 : Missed 2 spots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -33 lines) Patch
M codereview/views.py View 1 2 9 chunks +40 lines, -33 lines 0 comments Download

Messages

Total messages: 3
M-A
12 years, 5 months ago (2011-11-22 18:52:16 UTC) #1
Andi Albrecht
LGTM
12 years, 5 months ago (2011-11-22 19:04:28 UTC) #2
M-A
12 years, 5 months ago (2011-11-22 19:16:07 UTC) #3
FTR, I added 2 max_length in patchset #3.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b