Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5349)

Issue 54210049: Issue 3827: remove the necessity to have a \layout block in a \markup \score ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by dak
Modified:
10 years, 2 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3827: remove the necessity to have a \layout block in a \markup \score ... It turns out that this is not really fixable in the backend since what is called "layout" in the markup function definitions does not actually correspond to \layout but rather to \paper. Very funny. So this is solved in the parser itself when reading a \score or \score-lines to be used in a markup or markup list by cloning $defaultlayout as necessary (which simulates \layout {}) whenever the score does not already have a \layout block.

Patch Set 1 #

Patch Set 2 : Simplify the approach: only add \layout {} if there is no output def at all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M lily/parser.yy View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 2
dak
Simplify the approach: only add \layout {} if there is no output def at all
10 years, 2 months ago (2014-02-08 18:49:38 UTC) #1
janek
10 years, 2 months ago (2014-02-11 18:39:36 UTC) #2
Great news!  Previous situation was quite irritating.

(Sorry that i don't review the code, but i don't have time - nor mental
capability ATM - but i wanted to give you some encouragement.  Keep up great
work!)

Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b