Issue 5417044: Use ibus_input_context_process_key_event_async in ibus-x11

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5417044: Use ibus_input_context_process_key_event_async in ibus-x11 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by fujiwara

Modified:
12 years, 5 months ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Use ibus_input_context_process_key_event_async in ibus-x11 ibus-hangul calls ibus_commit_text() in process_key_event with returing FALSE. ibus_commit_text() is async API and there is a time issue in ibus_commit_text() and returning process_key_event. This fix adds async in ibus-x11 process_key_event too. BUG=RH#753781 TEST=Linux desktop

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated with Message #2 #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -19 lines)			Patch
	M	client/x11/main.c	View	1	5 chunks	+94 lines, -19 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm with several comments http://codereview.appspot.com/5417044/diff/1/client/x11/main.c File client/x11/main.c (right): http://codereview.appspot.com/5417044/diff/1/client/x11/main.c#newcode530 client/x11/main.c:530: pfe = g_new0 (IMForwardEventStruct, 1); ...

12 years, 5 months ago (2011-11-18 14:56:33 UTC) #2

fujiwara

12 years, 5 months ago (2011-11-21 02:05:23 UTC) #3

On 2011/11/18 14:56:33, Peng wrote:
> lgtm with several comments
> 
> http://codereview.appspot.com/5417044/diff/1/client/x11/main.c
> File client/x11/main.c (right):
> 
> http://codereview.appspot.com/5417044/diff/1/client/x11/main.c#newcode530
> client/x11/main.c:530: pfe = g_new0 (IMForwardEventStruct, 1);
> suggest using g_slice_new0() and g_slice_free()
> 
> http://codereview.appspot.com/5417044/diff/1/client/x11/main.c#newcode536
> client/x11/main.c:536: memcpy (&pfe->event, xevent, sizeof (XKeyEvent));
> Suggest using same code in line 521 & 536
> 
> http://codereview.appspot.com/5417044/diff/1/client/x11/main.c#newcode552
> client/x11/main.c:552: #undef _XIM_COPY_XKEYEVENT
> What is it?

Thanks, I updated the patch.

Expand All Messages | Collapse All Messages