Issue 5413050: Handle regexs that are applied to repeating parameters.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5413050: Handle regexs that are applied to repeating parameters. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by jcgregorio_google

Modified:
13 years, 8 months ago

Reviewers:
aiuto

CC:
google-api-python-client_googlegroups.com, silvano

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -4 lines)			Patch
M	apiclient/discovery.py	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	tests/data/zoo.json	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests/test_discovery.py	View	1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

aiuto

lgtm http://codereview.appspot.com/5413050/diff/1/tests/test_discovery.py File tests/test_discovery.py (right): http://codereview.appspot.com/5413050/diff/1/tests/test_discovery.py#newcode174 tests/test_discovery.py:174: 'bar']) maybe rr=[foo, bar] together on the next ...

13 years, 8 months ago (2011-11-18 19:19:37 UTC) #2

jcgregorio_google

13 years, 8 months ago (2011-11-18 19:36:49 UTC) #3

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=8cdc8935823...

On 2011/11/18 19:19:37, aiuto wrote:
> lgtm
> 
> http://codereview.appspot.com/5413050/diff/1/tests/test_discovery.py
> File tests/test_discovery.py (right):
> 
>
http://codereview.appspot.com/5413050/diff/1/tests/test_discovery.py#newcode174
> tests/test_discovery.py:174: 'bar'])
> maybe   rr=[foo, bar] together on the next line. Your call.

Expand All Messages | Collapse All Messages