Issue 5410050: Upstream android's change for angle

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5410050: Upstream android's change for angle (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by michaelbai

Modified:
12 years, 5 months ago

Reviewers:
jrg, dgkoch, jbauman, John Bauman

CC:
angleproject-review_googlegroups.com, Peter Beverloo

Base URL:
http://git.chromium.org/external/angleproject.git@master

Visibility:
Public.

More Reviews

Description

Upstream android's change for angle BUG= TEST= Committed: http://code.google.com/p/angleproject/source/detail?r=887

Patch Set 1 #

Patch Set 2 : Upstream android's change for angle #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	include/EGL/eglplatform.h	View	1	2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

John Bauman

On 2011/11/18 20:58:17, michaelbai wrote: > Hi John, > > Please help to review it ...

12 years, 5 months ago (2011-11-18 21:15:11 UTC) #3

dgkoch

12 years, 5 months ago (2011-11-19 13:51:38 UTC) #4

On 2011/11/18 21:15:11, John Bauman wrote:
> On 2011/11/18 20:58:17, michaelbai wrote:
> > Hi John,
> > 
> > Please help to review it
> 
> LGTM. Seems straightforward enough.

LGTM.  Would be good to maybe contribute these back to Khronos as well..

Expand All Messages | Collapse All Messages