Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5842)

Issue 54050043: stencil.scm: add make-path-stencil function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by pwm
Modified:
9 years, 3 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

stencil.scm: add make-path-stencil function supports all path commands both relative and absolute: lineto, rlineto, curveto, rcurveto, moveto, rmoveto, closepath also supports single letter syntax used in standard SVG path commands: L, l, C, c, M, m, Z, z. Refactors make-connected-path-stencil for backwards compatibility and continued use

Patch Set 1 #

Total comments: 2

Patch Set 2 : stencil.scm: minor edits, doc strings, comments #

Patch Set 3 : Add on-page-greater-than, -less-than (on-the-fly conditional markup procedures) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Documentation/notation/input.itely View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ly/titling-init.ly View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4
lemzwerg
https://codereview.appspot.com/54050043/diff/1/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/54050043/diff/1/scm/stencil.scm#newcode449 scm/stencil.scm:449: coordinates for the origin point of the path (used ...
10 years, 3 months ago (2014-01-18 04:52:50 UTC) #1
pwm
This patch introduces a make-path-stencil function that offers the benefits of the current make-connected-path-stencil function ...
10 years, 3 months ago (2014-01-18 05:14:50 UTC) #2
pwm
On 2014/01/18 04:52:50, lemzwerg wrote: > https://codereview.appspot.com/54050043/diff/1/scm/stencil.scm > File scm/stencil.scm (right): > > https://codereview.appspot.com/54050043/diff/1/scm/stencil.scm#newcode449 > ...
10 years, 3 months ago (2014-01-18 20:47:20 UTC) #3
pwm
10 years, 3 months ago (2014-01-21 02:15:25 UTC) #4
https://codereview.appspot.com/54050043/diff/1/scm/stencil.scm
File scm/stencil.scm (right):

https://codereview.appspot.com/54050043/diff/1/scm/stencil.scm#newcode449
scm/stencil.scm:449: coordinates for the origin point of the path (used for
closepath and
On 2014/01/18 04:52:51, lemzwerg wrote:
> A minor thing: We use two spaces after a full stop in documentation strings. 
> (At least it should be like that in general.)

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b