Issue 5375098: Add API "focusCandidate(size_t i)".

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5375098: Add API "focusCandidate(size_t i)". (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by hsumita

Modified:
12 years, 5 months ago

Reviewers:
shawn.p.huang, penghuang

CC:
komatsu, mukai, yusukes, nona, horo

Base URL:
git@github.com:pyzy/pyzy.git@master

Visibility:
Public.

More Reviews

Description

Add API "focusCandidate(size_t i)". BUG= None TEST= Build a package.

Patch Set 2 : Modify print format from %ud to %zd for size_t. #

Total comments: 1

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/PyZyInputContext.h	View		1 chunk	+1 line, -0 lines	1 comment	Download
	M	src/PyZyPhoneticContext.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

http://codereview.appspot.com/5375098/diff/3/src/PyZyInputContext.h File src/PyZyInputContext.h (right): http://codereview.appspot.com/5375098/diff/3/src/PyZyInputContext.h#newcode82 src/PyZyInputContext.h:82: virtual bool focusCandidate (size_t index) = 0; Which class ...

12 years, 6 months ago (2011-11-17 01:38:11 UTC) #2

hsumita

I am sorry that my explanation was not enough. This function is already implemented in ...

12 years, 6 months ago (2011-11-17 03:19:28 UTC) #3

lgtm

Expand All Messages | Collapse All Messages