Issue 5375057: code review 5375057: syscall: regenerate z-files for freebsd, openbsd

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5375057: code review 5375057: syscall: regenerate z-files for freebsd, openbsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by mikio

Modified:
13 years, 8 months ago

Reviewers:
jsing

CC:
golang-dev, rsc

Visibility:
Public.

Description

syscall: regenerate z-files for freebsd, openbsd

Patch Set 1 : diff -r 000602776246 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 000602776246 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 000602776246 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+739 lines, -680 lines)			Patch
M	src/pkg/syscall/zerrors_freebsd_386.go	View	18 chunks	+24 lines, -28 lines	0 comments	Download
M	src/pkg/syscall/zerrors_freebsd_amd64.go	View	18 chunks	+24 lines, -28 lines	0 comments	Download
M	src/pkg/syscall/zerrors_openbsd_386.go	View	23 chunks	+175 lines, -181 lines	0 comments	Download
M	src/pkg/syscall/zerrors_openbsd_amd64.go	View	17 chunks	+25 lines, -28 lines	0 comments	Download
M	src/pkg/syscall/ztypes_freebsd_386.go	View	10 chunks	+121 lines, -105 lines	0 comments	Download
M	src/pkg/syscall/ztypes_freebsd_amd64.go	View	13 chunks	+139 lines, -124 lines	0 comments	Download
M	src/pkg/syscall/ztypes_openbsd_386.go	View	10 chunks	+107 lines, -84 lines	0 comments	Download
M	src/pkg/syscall/ztypes_openbsd_amd64.go	View	13 chunks	+124 lines, -102 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-11-11 15:07:23 UTC) #1

mikio

*** Submitted as http://code.google.com/p/go/source/detail?r=6806723a8611 *** syscall: regenerate z-files for freebsd, openbsd R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5375057

13 years, 8 months ago (2011-11-11 15:22:29 UTC) #3

jsing

On 2011/11/11 15:22:29, mikioh wrote: > *** Submitted as http://code.google.com/p/go/source/detail?r=6806723a8611 *** > > syscall: regenerate ...

13 years, 8 months ago (2011-11-11 17:28:47 UTC) #4

mikio

13 years, 8 months ago (2011-11-12 12:44:37 UTC) #5

On Sat, Nov 12, 2011 at 2:28 AM,  <jsing@google.com> wrote:

>> http://codereview.appspot.com/5375057
>
> This change breaks builds on openbsd 386, due to zerrors_openbsd_386.go
> having unsigned constants specified as negative values. Looks like the
> dwarf data has the same issue the stabs has...

Sorry, thank you for the fix.

Expand All Messages | Collapse All Messages