Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(218)

Issue 5375044: Raise specific error on incorrect api name or version. Fixes issue #22 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by jcgregorio_google
Modified:
13 years, 7 months ago
Reviewers:
aiuto
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M apiclient/discovery.py View 2 chunks +4 lines, -0 lines 0 comments Download
M apiclient/errors.py View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 5
jcgregorio_google
13 years, 8 months ago (2011-11-09 20:07:51 UTC) #1
jcgregorio_google
13 years, 7 months ago (2011-11-17 15:06:34 UTC) #2
jcgregorio_google
13 years, 7 months ago (2011-11-18 13:14:12 UTC) #3
aiuto
lgtm http://codereview.appspot.com/5375044/diff/1/apiclient/errors.py File apiclient/errors.py (right): http://codereview.appspot.com/5375044/diff/1/apiclient/errors.py#newcode74 apiclient/errors.py:74: """No API with that name and version exists.""" ...
13 years, 7 months ago (2011-11-18 20:38:34 UTC) #4
jcgregorio_google
13 years, 7 months ago (2011-11-18 20:48:31 UTC) #5
Committed at 
http://code.google.com/p/google-api-python-client/source/detail?r=244902c5cb1...

http://codereview.appspot.com/5375044/diff/1/apiclient/errors.py
File apiclient/errors.py (right):

http://codereview.appspot.com/5375044/diff/1/apiclient/errors.py#newcode74
apiclient/errors.py:74: """No API with that name and version exists."""
On 2011/11/18 20:38:35, aiuto wrote:
> Maybe "UnknownApiNameOrVersion"?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b