Issue 5375044: Raise specific error on incorrect api name or version. Fixes issue #22

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5375044: Raise specific error on incorrect api name or version. Fixes issue #22 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by jcgregorio_google

Modified:
13 years, 8 months ago

Reviewers:
aiuto

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	apiclient/discovery.py	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	apiclient/errors.py	View		1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

aiuto

lgtm http://codereview.appspot.com/5375044/diff/1/apiclient/errors.py File apiclient/errors.py (right): http://codereview.appspot.com/5375044/diff/1/apiclient/errors.py#newcode74 apiclient/errors.py:74: """No API with that name and version exists.""" ...

13 years, 8 months ago (2011-11-18 20:38:34 UTC) #4

jcgregorio_google

13 years, 8 months ago (2011-11-18 20:48:31 UTC) #5

Committed at 
http://code.google.com/p/google-api-python-client/source/detail?r=244902c5cb1...

http://codereview.appspot.com/5375044/diff/1/apiclient/errors.py
File apiclient/errors.py (right):

http://codereview.appspot.com/5375044/diff/1/apiclient/errors.py#newcode74
apiclient/errors.py:74: """No API with that name and version exists."""
On 2011/11/18 20:38:35, aiuto wrote:
> Maybe "UnknownApiNameOrVersion"?

Done.

Expand All Messages | Collapse All Messages